fix(baremetal): handle errors in offer list command#5280
Merged
Mia-Cross merged 1 commit intoscaleway:masterfrom Jan 15, 2026
Merged
fix(baremetal): handle errors in offer list command#5280Mia-Cross merged 1 commit intoscaleway:masterfrom
Mia-Cross merged 1 commit intoscaleway:masterfrom
Conversation
remyleone
approved these changes
Jan 14, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5280 +/- ##
==========================================
- Coverage 56.96% 56.96% -0.01%
==========================================
Files 313 313
Lines 70256 70260 +4
==========================================
Hits 40023 40023
- Misses 28742 28744 +2
- Partials 1491 1493 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @Andarius, |
The ListOffers and ListPublicCatalogProducts API calls were ignoring errors, causing a nil pointer dereference when the API returned an error. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
auto-merge was automatically disabled
January 14, 2026 16:37
Head branch was pushed to by a user without write access
Andarius
force-pushed
the
fix/baremetal-offer-list-nil-pointer
branch
from
9600ae6 to
7e4a5e6
Compare
Contributor
Author
|
Hey @Mia-Cross, is this better? Or should I re open a PR with all the commits signed? |
Contributor
|
All good, thank you ! |
jremy42
pushed a commit
that referenced
this pull request
Feb 25, 2026
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
baremetal offer listcommandListOffersandListPublicCatalogProductsAPI callsDetails
The
ListOffersandListPublicCatalogProductsAPI calls were ignoring errors (using_), causing a nil pointer dereference when the API returned an error.Fixes #5278
Test plan
scw baremetal offer listwith invalid/missing credentials - should show proper error instead of panicscw baremetal offer listwith valid credentials - should work as before🤖 Generated with Claude Code