Skip to content

chore: fix lint#5263

Merged
remyleone merged 1 commit intoscaleway:masterfrom
remyleone:fix_lint
Jan 8, 2026
Merged

chore: fix lint#5263
remyleone merged 1 commit intoscaleway:masterfrom
remyleone:fix_lint

Conversation

@remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Copilot AI review requested due to automatic review settings January 8, 2026 10:25
@remyleone remyleone requested review from a team as code owners January 8, 2026 10:25
@remyleone remyleone requested review from jremy42 and removed request for a team January 8, 2026 10:25
@github-actions github-actions bot added registry Managed Container Registry issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests function Serverless function issues, bugs and feature requests labels Jan 8, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 35.79545% with 113 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.03%. Comparing base (6953eac) to head (c694585).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/namespaces/lb/v1/custom_backend.go 50.00% 24 Missing ⚠️
core/command_interceptor.go 0.00% 20 Missing ⚠️
...nal/namespaces/instance/v1/custom_server_action.go 25.00% 15 Missing ⚠️
internal/namespaces/k8s/v1/custom_pool.go 0.00% 14 Missing ⚠️
internal/qa/ignore.go 0.00% 7 Missing ⚠️
core/cobra_utils.go 45.45% 6 Missing ⚠️
...nal/namespaces/registry/v1/custom_docker_helper.go 0.00% 6 Missing ⚠️
core/example.go 0.00% 5 Missing ⚠️
internal/namespaces/instance/v1/custom_ssh_key.go 0.00% 4 Missing ⚠️
core/arg_specs.go 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5263      +/-   ##
==========================================
- Coverage   57.07%   57.03%   -0.04%     
==========================================
  Files         313      313              
  Lines       70088    70193     +105     
==========================================
+ Hits        40002    40037      +35     
- Misses      28593    28663      +70     
  Partials     1493     1493              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses linting violations by reformatting code to comply with Go linting standards. The changes focus on line length limits and slice initialization patterns.

Key changes:

  • Breaking long lines into multiple lines with proper indentation for function calls, format strings, and boolean expressions
  • Replacing []Type(nil) with make([]Type, 0, capacity) for slice initialization to preallocate capacity
  • Fixing struct tag formatting by removing extra whitespace

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/qa/ignore.go Wrapped long boolean expressions across multiple lines
internal/namespaces/registry/v1/custom_docker_helper.go Wrapped long string arguments for PrintlnWithoutIndent calls
internal/namespaces/rdb/v1/custom_acl.go Changed slice initialization to use make with capacity
internal/namespaces/object/v1/s3_helpers.go Changed slice initialization to use make with capacity
internal/namespaces/login/login.go Wrapped long warning message across multiple lines
internal/namespaces/lb/v1/custom_backend.go Wrapped multiple long fmt.Sprintf and error message calls
internal/namespaces/k8s/v1/types/types.go Removed extra whitespace from struct tag formatting
internal/namespaces/k8s/v1/custom_pool.go Combined slice initialization refactoring with line wrapping
internal/namespaces/instance/v1/custom_ssh_key.go Wrapped interactive.Println call across multiple lines
internal/namespaces/instance/v1/custom_ssh_config.go Wrapped logger.Warningf call across multiple lines
internal/namespaces/instance/v1/custom_server_create_builder.go Wrapped long function calls across multiple lines
internal/namespaces/instance/v1/custom_server_action.go Combined slice initialization with line wrapping for error messages
internal/namespaces/instance/v1/custom_server.go Changed slice initialization to use make with capacity
internal/namespaces/instance/v1/custom_image.go Changed slice initialization and reordered volume construction logic
internal/namespaces/function/v1beta1/custom_deploy.go Wrapped tasks.Add call across multiple lines
internal/namespaces/config/commands.go Changed slice initialization to use make with capacity
internal/args/args.go Changed slice initialization to use make with capacity
core/validate_test.go Wrapped assert.EqualError calls across multiple lines
core/reflect_test.go Wrapped t.Errorf calls across multiple lines
core/reflect.go Wrapped reflect.StructTag construction across multiple lines
core/human/marshal.go Changed slice initialization to use make with capacity
core/example.go Refactored slice construction using nested append pattern
core/default.go Changed slice initialization to use make with capacity
core/command_interceptor.go Wrapped multiple fmt.Sprintf and struct initialization calls
core/cobra_utils.go Wrapped error message construction across multiple lines
core/arg_specs.go Changed slice initialization to use make with capacity

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@remyleone remyleone added this pull request to the merge queue Jan 8, 2026
Merged via the queue into scaleway:master with commit a9d52a1 Jan 8, 2026
129 checks passed
@remyleone remyleone deleted the fix_lint branch January 8, 2026 11:02
jremy42 pushed a commit that referenced this pull request Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

function Serverless function issues, bugs and feature requests instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants