Skip to content

fix(instance): fix image listing zone handling#5262

Merged
remyleone merged 1 commit intoscaleway:masterfrom
remyleone:image_list_zone
Jan 8, 2026
Merged

fix(instance): fix image listing zone handling#5262
remyleone merged 1 commit intoscaleway:masterfrom
remyleone:image_list_zone

Conversation

@remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


Copilot AI review requested due to automatic review settings January 8, 2026 09:24
@remyleone remyleone requested a review from a team as a code owner January 8, 2026 09:24
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Jan 8, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.07%. Comparing base (0b27241) to head (0520111).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5262   +/-   ##
=======================================
  Coverage   57.07%   57.07%           
=======================================
  Files         313      313           
  Lines       70088    70089    +1     
=======================================
+ Hits        40002    40003    +1     
  Misses      28593    28593           
  Partials     1493     1493           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the instance image listing functionality where the zone parameter was not being properly passed from the command arguments to the API request.

  • Adds the missing Zone field assignment when constructing the ListImagesRequest

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@remyleone remyleone added this pull request to the merge queue Jan 8, 2026
Merged via the queue into scaleway:master with commit 6fd3389 Jan 8, 2026
128 of 129 checks passed
@remyleone remyleone deleted the image_list_zone branch January 8, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants