Skip to content

fix(vpc): handle IPAM errors gracefully in private-network get#5224

Merged
remyleone merged 1 commit intoscaleway:masterfrom
yfodil:fix/prevent-vpc-get-pn-fail
Dec 11, 2025
Merged

fix(vpc): handle IPAM errors gracefully in private-network get#5224
remyleone merged 1 commit intoscaleway:masterfrom
yfodil:fix/prevent-vpc-get-pn-fail

Conversation

@yfodil
Copy link
Contributor

@yfodil yfodil commented Dec 11, 2025

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@yfodil yfodil self-assigned this Dec 11, 2025
@yfodil yfodil requested a review from a team as a code owner December 11, 2025 09:55
@yfodil yfodil added bug vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Dec 11, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 35.29412% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.34%. Comparing base (abff741) to head (d34b704).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ternal/namespaces/vpc/v2/custom_private_network.go 35.29% 11 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5224      +/-   ##
==========================================
- Coverage   58.36%   58.34%   -0.03%     
==========================================
  Files         311      311              
  Lines       68512    68522      +10     
==========================================
- Hits        39990    39980      -10     
- Misses      27037    27047      +10     
- Partials     1485     1495      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone added this pull request to the merge queue Dec 11, 2025
Merged via the queue into scaleway:master with commit 06df160 Dec 11, 2025
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug vpc Virtual Private Cloud (VPC) issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants