Skip to content

feat(registry): add configurable timeout for tag deletion#5098

Merged
remyleone merged 3 commits intoscaleway:masterfrom
Mia-Cross:registry_tag_delete_add_timeout
Nov 5, 2025
Merged

feat(registry): add configurable timeout for tag deletion#5098
remyleone merged 3 commits intoscaleway:masterfrom
Mia-Cross:registry_tag_delete_add_timeout

Conversation

@Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross self-assigned this Oct 30, 2025
@Mia-Cross Mia-Cross added registry Managed Container Registry issues, bugs and feature requests enhancement labels Oct 30, 2025
@Mia-Cross Mia-Cross force-pushed the registry_tag_delete_add_timeout branch from 3d196b6 to 301aada Compare October 30, 2025 15:57
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 29.72973% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.45%. Comparing base (449138e) to head (ce35b4f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/testhelpers/helpers_registry.go 0.00% 45 Missing ⚠️
core/testing.go 0.00% 4 Missing ⚠️
internal/namespaces/registry/v1/custom_tag.go 87.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5098      +/-   ##
==========================================
+ Coverage   57.43%   57.45%   +0.01%     
==========================================
  Files         308      308              
  Lines       67218    67280      +62     
==========================================
+ Hits        38608    38657      +49     
- Misses      27173    27182       +9     
- Partials     1437     1441       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross force-pushed the registry_tag_delete_add_timeout branch from 0f22e12 to d4de211 Compare October 30, 2025 17:59
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label Oct 30, 2025
@Mia-Cross Mia-Cross force-pushed the registry_tag_delete_add_timeout branch from d4de211 to 38b4284 Compare November 3, 2025 09:15
@github-actions github-actions bot removed the instance Instance issues, bugs and feature requests label Nov 3, 2025
@Mia-Cross Mia-Cross marked this pull request as ready for review November 3, 2025 09:31
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners November 3, 2025 09:31
@Mia-Cross Mia-Cross force-pushed the registry_tag_delete_add_timeout branch from 9b35703 to 0f33809 Compare November 3, 2025 16:36
@remyleone remyleone added this pull request to the merge queue Nov 5, 2025
Merged via the queue into scaleway:master with commit 0ffc356 Nov 5, 2025
16 checks passed
@Mia-Cross Mia-Cross deleted the registry_tag_delete_add_timeout branch November 5, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement registry Managed Container Registry issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants