Skip to content

Conversation

@Mia-Cross
Copy link
Contributor

#4766 introduced a bug by getting snapshots using the zone of the volume, but this field is not present for SBS snapshots in the instance API.
We should use the zone of the image instead.

@Mia-Cross Mia-Cross self-assigned this Aug 1, 2025
@Mia-Cross Mia-Cross added bug instance Instance issues, bugs and feature requests labels Aug 1, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.21%. Comparing base (5bf53e0) to head (923e0bf).
⚠️ Report is 745 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (923e0bf). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (923e0bf)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4930       +/-   ##
===========================================
- Coverage   75.45%   56.21%   -19.24%     
===========================================
  Files         202      308      +106     
  Lines       44323    77790    +33467     
===========================================
+ Hits        33444    43731    +10287     
- Misses       9653    32656    +23003     
- Partials     1226     1403      +177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review August 1, 2025 10:00
@Mia-Cross Mia-Cross requested a review from a team as a code owner August 1, 2025 10:00
@Mia-Cross Mia-Cross added this pull request to the merge queue Aug 1, 2025
Merged via the queue into scaleway:master with commit 8a43bc4 Aug 1, 2025
20 of 21 checks passed
@Mia-Cross Mia-Cross deleted the instance_fix_snapshot_list_error branch August 1, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants