Skip to content

Conversation

@Mia-Cross
Copy link
Contributor

The function to get the End of Service date of a commercial type to display a warning if it's about to be deprecated was filtering results from the Product Catalog according to the product field. But the content of this field might change in the future, whereas the offer_id nested attribute will not, therefore we should use this field as a filter instead.

@Mia-Cross Mia-Cross self-assigned this Jul 8, 2025
@Mia-Cross Mia-Cross added the instance Instance issues, bugs and feature requests label Jul 8, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.43%. Comparing base (5bf53e0) to head (c21e12c).
Report is 710 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/helpers_types.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (c21e12c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (c21e12c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4879       +/-   ##
===========================================
- Coverage   75.45%   56.43%   -19.02%     
===========================================
  Files         202      315      +113     
  Lines       44323    78640    +34317     
===========================================
+ Hits        33444    44383    +10939     
- Misses       9653    32834    +23181     
- Partials     1226     1423      +197     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review July 9, 2025 12:45
@Mia-Cross Mia-Cross requested a review from a team as a code owner July 9, 2025 12:45
@remyleone remyleone added this pull request to the merge queue Jul 10, 2025
Merged via the queue into scaleway:master with commit e82ebab Jul 10, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants