Skip to content

feat(instance) fetch EoS date from PCU API and add it to warning #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2025

Conversation

Mia-Cross
Copy link
Contributor

No description provided.

@Mia-Cross Mia-Cross self-assigned this Jun 17, 2025
@Mia-Cross Mia-Cross added enhancement instance Instance issues, bugs and feature requests labels Jun 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 56.38%. Comparing base (5bf53e0) to head (4297a0b).
Report is 689 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/helpers_types.go 0.00% 27 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (4297a0b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (4297a0b)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4839       +/-   ##
===========================================
- Coverage   75.45%   56.38%   -19.07%     
===========================================
  Files         202      314      +112     
  Lines       44323    78347    +34024     
===========================================
+ Hits        33444    44177    +10733     
- Misses       9653    32764    +23111     
- Partials     1226     1406      +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross force-pushed the instance_add_date_to_eos_warning branch from d930384 to 2214003 Compare June 17, 2025 17:51
@Mia-Cross Mia-Cross marked this pull request as ready for review June 18, 2025 22:07
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners June 18, 2025 22:07
@remyleone remyleone enabled auto-merge June 19, 2025 07:40
@remyleone remyleone added this pull request to the merge queue Jun 19, 2025
Merged via the queue into scaleway:master with commit 7540992 Jun 19, 2025
15 checks passed
@Mia-Cross Mia-Cross deleted the instance_add_date_to_eos_warning branch June 19, 2025 08:06
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants