Skip to content

feat(serverless): add support for tags #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 2, 2025
Merged

feat(serverless): add support for tags #4699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b06984c
feat: update generated APIs
scaleway-bot Apr 30, 2025
4aec96f
Fix
remyleone May 2, 2025
9327795
Merge branch 'master' into v1.6461.0
remyleone May 2, 2025
45eef3c
Fix
remyleone May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-container-container-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ ARGS:
[health-check.http.path] Path to use for the HTTP health check.
[health-check.failure-threshold] Number of consecutive health check failures before considering the container unhealthy.
[health-check.interval] Period between health checks.
[tags.{index}] Tags of the Serverless Container
[deploy=true] Deploy container after creation
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

Expand Down
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-container-container-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ ARGS:
[health-check.http.path] Path to use for the HTTP health check.
[health-check.failure-threshold] Number of consecutive health check failures before considering the container unhealthy.
[health-check.interval] Period between health checks.
[tags.{index}] Tags of the Serverless Container
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

DEPRECATED ARGS:
Expand Down
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-container-namespace-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ ARGS:
[description] Description of the namespace to create
[secret-environment-variables.{index}.key]
[secret-environment-variables.{index}.value]
[tags.{index}] [ALPHA] Tags of the Serverless Container Namespace
[tags.{index}] Tags of the Serverless Container Namespace
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-container-namespace-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ARGS:
[description] Description of the namespace to update
[secret-environment-variables.{index}.key]
[secret-environment-variables.{index}.value]
[tags.{index}] [ALPHA] Tags of the Serverless Container Namespace
[tags.{index}] Tags of the Serverless Container Namespace
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-function-function-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ ARGS:
[secret-environment-variables.{index}.value]
[http-option=enabled] Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
[sandbox] Execution environment of the function (unknown_sandbox | v1 | v2)
[tags.{index}] Tags of the Serverless Function
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-function-function-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ ARGS:
[secret-environment-variables.{index}.value]
[http-option] Configure how HTTP and HTTPS requests are handled (unknown_http_option | enabled | redirected)
[sandbox] Execution environment of the function (unknown_sandbox | v1 | v2)
[tags.{index}] Tags of the Serverless Function
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-function-namespace-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ ARGS:
[description] Description of the namespace
[secret-environment-variables.{index}.key]
[secret-environment-variables.{index}.value]
[tags.{index}] [ALPHA] Tags of the Serverless Function Namespace
[tags.{index}] Tags of the Serverless Function Namespace
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-function-namespace-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ARGS:
[description] Description of the namespace
[secret-environment-variables.{index}.key]
[secret-environment-variables.{index}.value]
[tags.{index}] [ALPHA] Tags of the Serverless Function Namespace
[tags.{index}] Tags of the Serverless Function Namespace
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
6 changes: 4 additions & 2 deletions docs/commands/container.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ scw container container create [arg=value ...]
| health-check.http.path | | Path to use for the HTTP health check. |
| health-check.failure-threshold | | Number of consecutive health check failures before considering the container unhealthy. |
| health-check.interval | | Period between health checks. |
| tags.{index} | | Tags of the Serverless Container |
| deploy | Default: `true` | Deploy container after creation |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |

Expand Down Expand Up @@ -214,6 +215,7 @@ scw container container update <container-id ...> [arg=value ...]
| health-check.http.path | | Path to use for the HTTP health check. |
| health-check.failure-threshold | | Number of consecutive health check failures before considering the container unhealthy. |
| health-check.interval | | Period between health checks. |
| tags.{index} | | Tags of the Serverless Container |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down Expand Up @@ -474,7 +476,7 @@ scw container namespace create [arg=value ...]
| description | | Description of the namespace to create |
| secret-environment-variables.{index}.key | | |
| secret-environment-variables.{index}.value | | |
| tags.{index} | | [ALPHA] Tags of the Serverless Container Namespace |
| tags.{index} | | Tags of the Serverless Container Namespace |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down Expand Up @@ -562,7 +564,7 @@ scw container namespace update <namespace-id ...> [arg=value ...]
| description | | Description of the namespace to update |
| secret-environment-variables.{index}.key | | |
| secret-environment-variables.{index}.value | | |
| tags.{index} | | [ALPHA] Tags of the Serverless Container Namespace |
| tags.{index} | | Tags of the Serverless Container Namespace |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down
6 changes: 4 additions & 2 deletions docs/commands/function.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ scw function function create [arg=value ...]
| secret-environment-variables.{index}.value | | |
| http-option | Default: `enabled`<br />One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
| sandbox | One of: `unknown_sandbox`, `v1`, `v2` | Execution environment of the function |
| tags.{index} | | Tags of the Serverless Function |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down Expand Up @@ -463,6 +464,7 @@ scw function function update <function-id ...> [arg=value ...]
| secret-environment-variables.{index}.value | | |
| http-option | One of: `unknown_http_option`, `enabled`, `redirected` | Configure how HTTP and HTTPS requests are handled |
| sandbox | One of: `unknown_sandbox`, `v1`, `v2` | Execution environment of the function |
| tags.{index} | | Tags of the Serverless Function |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down Expand Up @@ -493,7 +495,7 @@ scw function namespace create [arg=value ...]
| description | | Description of the namespace |
| secret-environment-variables.{index}.key | | |
| secret-environment-variables.{index}.value | | |
| tags.{index} | | [ALPHA] Tags of the Serverless Function Namespace |
| tags.{index} | | Tags of the Serverless Function Namespace |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down Expand Up @@ -581,7 +583,7 @@ scw function namespace update <namespace-id ...> [arg=value ...]
| description | | Description of the namespace |
| secret-environment-variables.{index}.key | | |
| secret-environment-variables.{index}.value | | |
| tags.{index} | | [ALPHA] Tags of the Serverless Function Namespace |
| tags.{index} | | Tags of the Serverless Function Namespace |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down
18 changes: 16 additions & 2 deletions internal/namespaces/container/v1beta1/container_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ func containerNamespaceCreate() *core.Command {
},
{
Name: "tags.{index}",
Short: `[ALPHA] Tags of the Serverless Container Namespace`,
Short: `Tags of the Serverless Container Namespace`,
Required: false,
Deprecated: false,
Positional: false,
Expand Down Expand Up @@ -339,7 +339,7 @@ func containerNamespaceUpdate() *core.Command {
},
{
Name: "tags.{index}",
Short: `[ALPHA] Tags of the Serverless Container Namespace`,
Short: `Tags of the Serverless Container Namespace`,
Required: false,
Deprecated: false,
Positional: false,
Expand Down Expand Up @@ -708,6 +708,13 @@ func containerContainerCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "tags.{index}",
Short: `Tags of the Serverless Container`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down Expand Up @@ -923,6 +930,13 @@ func containerContainerUpdate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "tags.{index}",
Short: `Tags of the Serverless Container`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/file/v1alpha1/file_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"reflect"

"github.com/scaleway/scaleway-cli/v2/core"
"github.com/scaleway/scaleway-sdk-go/api/file/v1alpha1"
file "github.com/scaleway/scaleway-sdk-go/api/file/v1alpha1"
"github.com/scaleway/scaleway-sdk-go/scw"
)

Expand Down
18 changes: 16 additions & 2 deletions internal/namespaces/function/v1beta1/function_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ func functionNamespaceCreate() *core.Command {
},
{
Name: "tags.{index}",
Short: `[ALPHA] Tags of the Serverless Function Namespace`,
Short: `Tags of the Serverless Function Namespace`,
Required: false,
Deprecated: false,
Positional: false,
Expand Down Expand Up @@ -386,7 +386,7 @@ func functionNamespaceUpdate() *core.Command {
},
{
Name: "tags.{index}",
Short: `[ALPHA] Tags of the Serverless Function Namespace`,
Short: `Tags of the Serverless Function Namespace`,
Required: false,
Deprecated: false,
Positional: false,
Expand Down Expand Up @@ -721,6 +721,13 @@ func functionFunctionCreate() *core.Command {
"v2",
},
},
{
Name: "tags.{index}",
Short: `Tags of the Serverless Function`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down Expand Up @@ -903,6 +910,13 @@ func functionFunctionUpdate() *core.Command {
"v2",
},
},
{
Name: "tags.{index}",
Short: `Tags of the Serverless Function`,
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down
Loading