feat(block): add volume wait command#4434
Merged
remyleone merged 2 commits intoscaleway:masterfrom Jan 17, 2025
Merged
Conversation
8ac82f9 to
2a556d2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4434 +/- ##
==========================================
- Coverage 75.45% 70.72% -4.73%
==========================================
Files 202 298 +96
Lines 44323 66078 +21755
==========================================
+ Hits 33444 46734 +13290
- Misses 9653 17698 +8045
- Partials 1226 1646 +420 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
063f01f to
a0f3733
Compare
remyleone
approved these changes
Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be great to be able to wait for a volume to be detached. Some of our instance's tests currently use
instance volume waitbut will need this new command when we switch to sbs volumes.