Skip to content

chore: add support for sweepers #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 26, 2024
Merged

chore: add support for sweepers #4379

merged 11 commits into from
Dec 26, 2024

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@remyleone remyleone self-assigned this Dec 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 128 lines in your changes missing coverage. Please review.

Project coverage is 70.70%. Comparing base (5bf53e0) to head (f44b3f2).
Report is 412 commits behind head on master.

Files with missing lines Patch % Lines
cmd/scw-sweeper/main.go 0.00% 128 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4379      +/-   ##
==========================================
- Coverage   75.45%   70.70%   -4.76%     
==========================================
  Files         202      297      +95     
  Lines       44323    65859   +21536     
==========================================
+ Hits        33444    46564   +13120     
- Misses       9653    17654    +8001     
- Partials     1226     1641     +415     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone marked this pull request as ready for review December 26, 2024 09:26
@remyleone remyleone linked an issue Dec 26, 2024 that may be closed by this pull request
@remyleone remyleone added this pull request to the merge queue Dec 26, 2024
Merged via the queue into scaleway:master with commit 0781019 Dec 26, 2024
13 checks passed
@remyleone remyleone deleted the sweepers branch December 26, 2024 13:27
@remyleone remyleone linked an issue Mar 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a scw-sweeper command Clean up instances resources after the nightly tests are run
3 participants