Skip to content

chore(instance): extract server delete command from custom_server.go#4366

Merged
remyleone merged 2 commits intoscaleway:masterfrom
Codelax:chore/instance-move-server-delete
Dec 18, 2024
Merged

chore(instance): extract server delete command from custom_server.go#4366
remyleone merged 2 commits intoscaleway:masterfrom
Codelax:chore/instance-move-server-delete

Conversation

@Codelax
Copy link
Copy Markdown
Member

@Codelax Codelax commented Dec 17, 2024

Little refactor to make #4149 readable. I only did a copy, there is no logical changes.

@Codelax Codelax added the instance Instance issues, bugs and feature requests label Dec 17, 2024
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 75.13812% with 45 lines in your changes missing coverage. Please review.

Project coverage is 70.88%. Comparing base (5bf53e0) to head (13ed6b0).
Report is 399 commits behind head on master.

Files with missing lines Patch % Lines
...nal/namespaces/instance/v1/custom_server_delete.go 75.13% 37 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4366      +/-   ##
==========================================
- Coverage   75.45%   70.88%   -4.57%     
==========================================
  Files         202      296      +94     
  Lines       44323    65533   +21210     
==========================================
+ Hits        33444    46454   +13010     
- Misses       9653    17448    +7795     
- Partials     1226     1631     +405     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Dec 18, 2024
Merged via the queue into scaleway:master with commit bd71f0e Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants