feat(docs): Add minimum configuration for CLI docs PoC#4136
Merged
Conversation
SamyOubouaziz
added
enhancement
documentation
github_actions
SamyOubouaziz
had a problem deploying
to
actions
GitHub Actions
Failure
SamyOubouaziz
had a problem deploying
to
actions
GitHub Actions
Failure
SamyOubouaziz
had a problem deploying
to
actions
GitHub Actions
Failure
SamyOubouaziz
had a problem deploying
to
actions
GitHub Actions
Failure
SamyOubouaziz
had a problem deploying
to
actions
GitHub Actions
Failure
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
temporarily deployed
to
actions
GitHub Actions
Inactive
SamyOubouaziz
commented
Nov 28, 2024
Comment on lines
+2
to
+7
| on: | ||
| release: | ||
| types: | ||
| - published # Triggered only when a new release is published | ||
| branches: | ||
| - master |
Contributor
Author
There was a problem hiding this comment.
The expected behavior is: build and deploy when a new release is published. Could you check if this is the proper configuration?
SamyOubouaziz
commented
Nov 28, 2024
Comment on lines
+18
to
+22
| ref: ${{ github.event.release.tag_name }} | ||
| - name: Verify release commit | ||
| run: | # Commit hash to compare with the commit returned by actions/checkout@v4 - Tag to compare with the latest release | ||
| echo "Checked out commit: $(git rev-parse HEAD)" | ||
| echo "Expected tag: ${{ github.event.release.tag_name }}" |
Contributor
Author
There was a problem hiding this comment.
This part is supposed to check out the release commit and allow to compare checked out commit and release commit/tag.
Could you check if this is set properly ?
SamyOubouaziz
force-pushed
the
feat/create-cli-doc-website-poc
branch
from
ade2ccb to
515ba4f
Compare
jremy42
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scaleway CLI documentation PoC: