Skip to content

feat(instance): deprecate use of nat for IP #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 9, 2024
Merged

feat(instance): deprecate use of nat for IP #4105

merged 6 commits into from
Sep 9, 2024
+14 −14

Conversation

scaleway-bot
Copy link
Contributor

No description provided.

@github-actions github-actions bot added instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests billing Billing issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests account Account issues, bugs and feature requests dedibox Dedibox issues, bugs and feature requests labels Sep 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (5bf53e0) to head (beeb01a).
Report is 237 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4105      +/-   ##
==========================================
- Coverage   75.45%   72.40%   -3.06%     
==========================================
  Files         202      289      +87     
  Lines       44323    53766    +9443     
==========================================
+ Hits        33444    38929    +5485     
- Misses       9653    13240    +3587     
- Partials     1226     1597     +371

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed vpc Virtual Private Cloud (VPC) issues, bugs and feature requests account Account issues, bugs and feature requests dedibox Dedibox issues, bugs and feature requests labels Sep 9, 2024
@github-actions github-actions bot removed tem Transactional Email issues, bugs and feature requests billing Billing issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests labels Sep 9, 2024
@remyleone remyleone changed the title feat: update generated APIs feat(instance): deprecate use of nat Sep 9, 2024
@remyleone remyleone changed the title feat(instance): deprecate use of nat feat(instance): deprecate use of nat for IP Sep 9, 2024
@remyleone remyleone enabled auto-merge September 9, 2024 08:28
@remyleone remyleone added this pull request to the merge queue Sep 9, 2024
Merged via the queue into scaleway:master with commit a774083 Sep 9, 2024
13 checks passed
@remyleone remyleone deleted the manual_1725640235 branch September 9, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

@yfodil yfodil Awaiting requested review from yfodil

@jremy42 jremy42 Awaiting requested review from jremy42

@Codelax Codelax Awaiting requested review from Codelax

Assignees
No one assigned
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scaleway-bot @codecov-commenter @remyleone