Skip to content

chore: export core package and transition GetCommands to its own package #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@remyleone remyleone marked this pull request as draft August 30, 2024 09:42
@github-actions github-actions bot added registry Managed Container Registry issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests instance Instance issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests iot IoT issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests domain Domains issues, bugs and feature requests container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests iam IAM issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests billing Billing issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests account Account issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests dedibox Dedibox issues, bugs and feature requests baremetal vpcgw sdb labels Aug 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.40%. Comparing base (5bf53e0) to head (5b2f3e4).
Report is 272 commits behind head on master.

Files with missing lines Patch % Lines
cmd/scw-doc-gen/main.go 0.00% 2 Missing ⚠️
cmd/scw-qa/main.go 0.00% 2 Missing ⚠️
cmd/scw/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4093      +/-   ##
==========================================
- Coverage   75.45%   72.40%   -3.06%     
==========================================
  Files         202      289      +87     
  Lines       44323    53766    +9443     
==========================================
+ Hits        33444    38929    +5485     
- Misses       9653    13240    +3587     
- Partials     1226     1597     +371     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone marked this pull request as ready for review September 9, 2024 08:50
@Codelax Codelax added this pull request to the merge queue Sep 9, 2024
Merged via the queue into scaleway:master with commit 7f069ea Sep 9, 2024
13 checks passed
@remyleone remyleone deleted the extract_core branch September 9, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Account issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests baremetal billing Billing issues, bugs and feature requests container Container issues, bugs and feature requests dedibox Dedibox issues, bugs and feature requests domain Domains issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests iam IAM issues, bugs and feature requests instance Instance issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests sdb secret Managed Secret Manager issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw webhosting Webhosting issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants