Skip to content

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Aug 16, 2024

Close #3881

@Codelax Codelax added enhancement init iam IAM issues, bugs and feature requests labels Aug 16, 2024
@github-actions github-actions bot removed the iam IAM issues, bugs and feature requests label Aug 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 48.79518% with 85 lines in your changes missing coverage. Please review.

Project coverage is 69.34%. Comparing base (5bf53e0) to head (83727cd).
Report is 216 commits behind head on master.

Files Patch % Lines
internal/namespaces/login/login.go 28.75% 56 Missing and 1 partial ⚠️
...ternal/namespaces/login/webcallback/webcallback.go 65.75% 17 Missing and 8 partials ⚠️
internal/namespaces/login/webcallback/options.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (83727cd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (83727cd)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4043      +/-   ##
==========================================
- Coverage   75.45%   69.34%   -6.11%     
==========================================
  Files         202      295      +93     
  Lines       44323    55830   +11507     
==========================================
+ Hits        33444    38717    +5273     
- Misses       9653    15525    +5872     
- Partials     1226     1588     +362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review August 27, 2024 07:52
@Codelax Codelax requested a review from remyleone as a code owner August 27, 2024 07:52
@remyleone remyleone added this pull request to the merge queue Aug 27, 2024
Merged via the queue into scaleway:master with commit 642b368 Aug 27, 2024
13 checks passed
@Codelax Codelax linked an issue Sep 17, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scw login Have a login command
3 participants