Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Jun 7, 2024

  • Add --wait to scw instance server get-rdp-password.
  • Add admin-password-encryption-ssh-key-id with completion to scw instance server {create,update}
  • Make admin-password-encryption-ssh-key-id required when creating a Windows server. This avoid confusion as password will not be generated without a ssh key id.

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Jun 7, 2024
@Codelax Codelax self-assigned this Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 74.50980% with 13 lines in your changes missing coverage. Please review.

Project coverage is 72.50%. Comparing base (5bf53e0) to head (4a44ed1).
Report is 90 commits behind head on master.

Files Patch % Lines
...ternal/namespaces/instance/v1/custom_server_rdp.go 59.37% 11 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3863      +/-   ##
==========================================
- Coverage   75.45%   72.50%   -2.95%     
==========================================
  Files         202      287      +85     
  Lines       44323    51022    +6699     
==========================================
+ Hits        33444    36995    +3551     
- Misses       9653    12512    +2859     
- Partials     1226     1515     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax force-pushed the feat/instance-server-improve-windows-support branch from 71adc8d to 5452834 Compare June 7, 2024 12:35
@Codelax Codelax force-pushed the feat/instance-server-improve-windows-support branch from ad3345f to 62dba26 Compare June 7, 2024 13:13
@Codelax Codelax marked this pull request as ready for review June 7, 2024 13:21
@Codelax Codelax requested a review from remyleone as a code owner June 7, 2024 13:21
@remyleone remyleone added this pull request to the merge queue Jun 11, 2024
Merged via the queue into scaleway:master with commit d942896 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement instance Instance issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants