Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Apr 9, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added the iam IAM issues, bugs and feature requests label Apr 9, 2024
@Codelax Codelax self-assigned this Apr 9, 2024
@Codelax Codelax changed the title feat(iam): show rules with policy feat(iam): improve rules handling Apr 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 82.06897% with 26 lines in your changes missing coverage. Please review.

Project coverage is 77.22%. Comparing base (5bf53e0) to head (42401f7).
Report is 272 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/iam/v1alpha1/custom_policy.go 57.89% 13 Missing and 3 partials ⚠️
internal/namespaces/iam/v1alpha1/custom_rule.go 90.19% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3753      +/-   ##
==========================================
+ Coverage   75.45%   77.22%   +1.76%     
==========================================
  Files         202      204       +2     
  Lines       44323    37272    -7051     
==========================================
- Hits        33444    28783    -4661     
+ Misses       9653     7255    -2398     
- Partials     1226     1234       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone added this pull request to the merge queue Apr 10, 2024
Merged via the queue into scaleway:master with commit e2e9309 Apr 10, 2024
jremy42 pushed a commit to jremy42/scaleway-cli that referenced this pull request Apr 12, 2024
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement iam IAM issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants