Introduce Logger#369
Merged
moul merged 3 commits intoscaleway:masterfrom Jun 21, 2016
nicolai86:feature/introduce-logging-interface
Merged
Introduce Logger#369moul merged 3 commits intoscaleway:masterfrom nicolai86:feature/introduce-logging-interface
moul merged 3 commits intoscaleway:masterfrom
nicolai86:feature/introduce-logging-interface
Conversation
| Log(...interface{}) | ||
| } | ||
|
|
||
| func NewDefaultLogger() Logger { |
There was a problem hiding this comment.
exported function NewDefaultLogger should have comment or be unexported
Author
|
@QuentinPerez thanks for improving the PR! If you have other changes in mind let me know; also if you want to have the commits squashed or rebased, to conform commit msg guidelines. |
|
LGTM, ping @moul 😊 |
|
LGTM, thank you |
|
Well done guys |
|
@QuentinPerez can you credit @nicolai86 in the changelog ? |
Author
|
Thanks for being so responsive! I'll continue my quest to get scaleway into terraform, then. 🙏🏼 |
Author
|
For those interested in the progress of the terraform provider, you can take a look here: hashicorp/terraform#7331 |
clement-gilbert
pushed a commit
to clement-gilbert/scaleway-cli
that referenced
this pull request
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #368 this PR introduces a
Loggerinterface which allows us to extract thehttp2curlandlogrusdependencies into thecli&commandpackages.The
Loggercontains two functions -LogHTTPto handlehttp.Request, andLogfor plainstring.The
cliconfigures theScalewayAPIinstance to retain the old logging behaviour. By default, the logging is not very verbose, logging only messages & API endpoints being used.Also, I've replaced
anonuuidwith static, fake uuids. Not sure why we need "randomized" uuids if the only concern is to sanitize logs from real credentials.