fix(instance): explicitly set IP type based on routed-ip-enabled value#3668
Merged
Codelax merged 1 commit intoscaleway:masterfrom Feb 21, 2024
Merged
fix(instance): explicitly set IP type based on routed-ip-enabled value#3668Codelax merged 1 commit intoscaleway:masterfrom
Codelax merged 1 commit intoscaleway:masterfrom
Conversation
The default values for 'server.routed-ip-enabled' and 'ip.type' will change in a near future. This fix ensures we always set the ip.type accordingly with the context. Without this change, users will end up with the following error: ``` ❯ scw instance server create routed-ip-enabled=false Cannot create the server: scaleway-sdk-go: http error 400 Bad Request: cannot attach ip of type 'routed' ```
d2ec4ac to
83ffbda
Compare
Codelax
approved these changes
Feb 21, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3668 +/- ##
=======================================
Coverage 75.87% 75.87%
=======================================
Files 189 189
Lines 42597 42599 +2
=======================================
+ Hits 32319 32321 +2
+ Misses 9091 9090 -1
- Partials 1187 1188 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default values for 'server.routed-ip-enabled' and 'ip.type' will change in a near future.
This fix ensures we always set the ip.type accordingly with the context.
Without this change, users will end up with the following error:
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: