Skip to content

fix(golangci-lint): update code to fix ci#3653

Merged
remyleone merged 3 commits intoscaleway:masterfrom
Laure-di:fix/golangci-lint-update-fix
Feb 12, 2024
Merged

fix(golangci-lint): update code to fix ci#3653
remyleone merged 3 commits intoscaleway:masterfrom
Laure-di:fix/golangci-lint-update-fix

Conversation

@Laure-di
Copy link
Contributor

@Laure-di Laure-di commented Feb 9, 2024

close #3652

@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (7f39070) 75.76% compared to head (0cd090d) 75.76%.

Files Patch % Lines
internal/human/marshal_func.go 30.76% 0 Missing and 9 partials ⚠️
...ernal/namespaces/function/v1beta1/custom_deploy.go 40.00% 1 Missing and 2 partials ⚠️
internal/core/arg_specs.go 0.00% 2 Missing ⚠️
...nal/namespaces/registry/v1/custom_docker_helper.go 50.00% 0 Missing and 2 partials ⚠️
internal/core/socket_passthrough_transport.go 0.00% 0 Missing and 1 partial ⚠️
internal/core/testing.go 0.00% 0 Missing and 1 partial ⚠️
internal/namespaces/config/commands.go 90.00% 0 Missing and 1 partial ⚠️
internal/namespaces/iam/v1alpha1/custom.go 0.00% 0 Missing and 1 partial ⚠️
...nal/namespaces/instance/v1/custom_server_action.go 0.00% 1 Missing ⚠️
internal/namespaces/lb/v1/custom_lb.go 66.66% 0 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3653   +/-   ##
=======================================
  Coverage   75.76%   75.76%           
=======================================
  Files         183      183           
  Lines       41276    41276           
=======================================
  Hits        31272    31272           
  Misses       8860     8860           
  Partials     1144     1144           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone enabled auto-merge February 12, 2024 16:49
@remyleone remyleone added this pull request to the merge queue Feb 12, 2024
Merged via the queue into scaleway:master with commit bb53bb3 Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update golangci-lint and fix

4 participants