fix/shell-display-how-to-quit#3635
Merged
remyleone merged 1 commit intoscaleway:masterfrom Feb 7, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3635 +/- ##
==========================================
- Coverage 75.86% 75.81% -0.05%
==========================================
Files 180 180
Lines 41066 41229 +163
==========================================
+ Hits 31153 31258 +105
- Misses 8777 8830 +53
- Partials 1136 1141 +5 ☔ View full report in Codecov by Sentry. |
Laure-di
force-pushed
the
fix/shell-display-how-to-quit
branch
from
aa69979 to
94af800
Compare
Member
|
There is an issue using this PR's branch: |
Laure-di
force-pushed
the
fix/shell-display-how-to-quit
branch
from
94af800 to
c1e6f9e
Compare
remyleone
reviewed
Feb 6, 2024
internal/core/shell.go
Outdated
| meta.Commands.Remove("shell", "") | ||
|
|
||
| executor := shellExecutor(rootCmd, printer, meta) | ||
| fmt.Println("- Type Ctrl+d to quit.") |
Member
There was a problem hiding this comment.
Could you extract this to a variable?
That way we will be able to add more content and make it more welcoming.
Maybe adding some colors in addition down the road :)
Codelax
reviewed
Feb 6, 2024
internal/namespaces/shell/shell.go
Outdated
| AllowAnonymousClient: false, | ||
| ArgsType: reflect.TypeOf(args.RawArgs{}), | ||
| Run: func(ctx context.Context, argsI interface{}) (interface{}, error) { | ||
| fmt.Println(" - Type Ctrl+d to quit.") |
Member
There was a problem hiding this comment.
There is no need for both prints. This one can go as this is never called
Laure-di
force-pushed
the
fix/shell-display-how-to-quit
branch
2 times, most recently
from
16bb381 to
bde7715
Compare
Laure-di
force-pushed
the
fix/shell-display-how-to-quit
branch
from
bde7715 to
4af757e
Compare
remyleone
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #3621