Skip to content

feat(instance): auto completion in rdb instance command#3605

Merged
remyleone merged 1 commit intoscaleway:masterfrom
jremy42:fix/completion_in_rdb_commands
Jan 22, 2024
Merged

feat(instance): auto completion in rdb instance command#3605
remyleone merged 1 commit intoscaleway:masterfrom
jremy42:fix/completion_in_rdb_commands

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Jan 22, 2024

close #3293

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

❌ Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.78%. Comparing base (e110d2d) to head (d3e8161).
⚠️ Report is 1092 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/rdb/v1/custom_instance.go 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3605      +/-   ##
==========================================
- Coverage   75.86%   75.78%   -0.08%     
==========================================
  Files         180      180              
  Lines       41066    41110      +44     
==========================================
+ Hits        31153    31157       +4     
- Misses       8777     8816      +39     
- Partials     1136     1137       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jremy42 jremy42 force-pushed the fix/completion_in_rdb_commands branch from bebcd1d to d3e8161 Compare January 22, 2024 10:09
@Codelax Codelax changed the title feat(instance):auto completion in rdb instance command feat(instance): auto completion in rdb instance command Jan 22, 2024
@remyleone remyleone added this pull request to the merge queue Jan 22, 2024
Merged via the queue into scaleway:master with commit 35294a9 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for engine completion in rdb commands

3 participants