Skip to content

fix(vpc):better rendering of subnet in private network#3600

Merged
remyleone merged 1 commit intoscaleway:masterfrom
jremy42:fix/improve_rendering_subnet_of_private_network
Mar 13, 2024
Merged

fix(vpc):better rendering of subnet in private network#3600
remyleone merged 1 commit intoscaleway:masterfrom
jremy42:fix/improve_rendering_subnet_of_private_network

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Jan 19, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


close #3322

@jremy42 jremy42 force-pushed the fix/improve_rendering_subnet_of_private_network branch from 424522b to f83b357 Compare January 19, 2024 15:52
@jremy42 jremy42 force-pushed the fix/improve_rendering_subnet_of_private_network branch from f83b357 to b1b5a6b Compare January 22, 2024 10:30
@remyleone
Copy link
Member

$ go run ./cmd/scw vpc private-network list
---------------------------------------------------------------------------------------
An error occurred, we are sorry, please consider opening a ticket on github using: 'scw feedback bug'
Give us as many details as possible so we can reproduce the error and fix it.
---------------------------------------------------------------------------------------
runtime error: invalid memory address or nil pointer dereference
stacktrace from panic: 
goroutine 1 [running]:
runtime/debug.Stack()
        /opt/homebrew/opt/go/libexec/src/runtime/debug/stack.go:24 +0x64
main.cleanup(0x14000237340)
        /Users/rleone/workspace/scaleway-cli/cmd/scw/main.go:42 +0xb4
panic({0x1018ccfe0?, 0x1026b63f0?})
        /opt/homebrew/opt/go/libexec/src/runtime/panic.go:914 +0x218
github.com/scaleway/scaleway-cli/v2/internal/namespaces/vpc/v2.privateNetworkSubnetMarshalerFunc({0x10181e000?, 0x14000633140?}, 0x0)
        /Users/rleone/workspace/scaleway-cli/internal/namespaces/vpc/v2/custom_private_network.go:24 +0x1cc
github.com/scaleway/scaleway-cli/v2/internal/human.marshalInlineSlice({0x10181e000, 0x14000633140, 0x97})
        /Users/rleone/workspace/scaleway-cli/internal/human/marshal.go:359 +0x250
github.com/scaleway/scaleway-cli/v2/internal/human.marshalSlice({0x10181e240?, 0x140006330c8?, 0x1018e98e0?}, 0x14000102e10)
        /Users/rleone/workspace/scaleway-cli/internal/human/marshal.go:326 +0x6d0
github.com/scaleway/scaleway-cli/v2/internal/human.Marshal({0x10181e240, 0x140006330c8}, 0x140006330c8?)
        /Users/rleone/workspace/scaleway-cli/internal/human/marshal.go:81 +0x2fc
github.com/scaleway/scaleway-cli/v2/internal/core.(*Printer).printHuman(0x14000100d20, {0x10181e240, 0x140006330c8}, 0x0)
        /Users/rleone/workspace/scaleway-cli/internal/core/printer.go:202 +0x15c
github.com/scaleway/scaleway-cli/v2/internal/core.(*Printer).Print(0x14000100d20, {0x10181e240?, 0x140006330c8?}, 0x10149e50a?)
        /Users/rleone/workspace/scaleway-cli/internal/core/printer.go:159 +0x12c
github.com/scaleway/scaleway-cli/v2/internal/core.Bootstrap(0x14000713e70)
        /Users/rleone/workspace/scaleway-cli/internal/core/bootstrap.go:281 +0x11c4
main.main()
        /Users/rleone/workspace/scaleway-cli/cmd/scw/main.go:74 +0x314

@jremy42 jremy42 force-pushed the fix/improve_rendering_subnet_of_private_network branch from b1b5a6b to d246afa Compare January 22, 2024 13:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

❌ Patch coverage is 48.83721% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.58%. Comparing base (833fb65) to head (5f50208).
⚠️ Report is 781 commits behind head on master.

Files with missing lines Patch % Lines
internal/namespaces/instance/v1/custom_server.go 17.39% 18 Missing and 1 partial ⚠️
...ternal/namespaces/vpc/v2/custom_private_network.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3600      +/-   ##
==========================================
- Coverage   75.61%   75.58%   -0.03%     
==========================================
  Files         196      196              
  Lines       43375    43417      +42     
==========================================
+ Hits        32799    32818      +19     
- Misses       9374     9395      +21     
- Partials     1202     1204       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone marked this pull request as draft February 16, 2024 15:39
@jremy42 jremy42 force-pushed the fix/improve_rendering_subnet_of_private_network branch 2 times, most recently from 6fc6312 to e456ba2 Compare February 20, 2024 13:05
@jremy42 jremy42 marked this pull request as ready for review February 20, 2024 15:32
@Codelax
Copy link
Member

Codelax commented Feb 22, 2024

scw vpc private-network list does not crash anymore but the rendering is still off:

❯ scw vpc pn list -owide
ID                                    NAME             ORGANIZATION ID                       PROJECT ID                            REGION  TAGS                                             CREATED AT   UPDATED AT   SUBNETS  VPC ID  DHCP ENABLED
eafcee16-4658-4690-84d6-ad2d8d576cc4  pn-happy-turing  ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b  ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b  fr-par  [created-along-with-k8s-cluster created-by-cli]  3 weeks ago  3 weeks ago  ID                                    Subnet                    Created at   Updated at
6ed2866b-5224-4e98-a22f-12154b9726fd  172.16.16.0/22            3 weeks ago  3 weeks ago
e31b3ba1-6bfb-4245-b1ca-fcf5fd738e55  fd4a:c18e:554d:bc85::/64  3 weeks ago  3 weeks ago  53e50f63-f6c0-44f7-8576-d6edcb965d9c  true
23e11465-6939-4c30-a14e-761beac5740b                                                      pn-thirsty-diffie                     ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b  ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b  fr-par  [created-along-with-k8s-cluster created-by-cli]  1 week ago  1 week ago  ID                                    Subnet                    Created at  Updated at
56a8174c-a7c7-494e-bb87-341dd173a056  172.16.8.0/22             1 week ago  1 week ago
c8fdb28f-63a8-44bf-b59d-52b89c7c3a9e  fd4a:c18e:554d:208a::/64  1 week ago  1 week ago  53e50f63-f6c0-44f7-8576-d6edcb965d9c  true


@jremy42 jremy42 force-pushed the fix/improve_rendering_subnet_of_private_network branch 2 times, most recently from 6b2c795 to 60a9b70 Compare March 5, 2024 10:57
@jremy42
Copy link
Contributor Author

jremy42 commented Mar 5, 2024

fix !

@jremy42 jremy42 force-pushed the fix/improve_rendering_subnet_of_private_network branch from 60a9b70 to 5f50208 Compare March 13, 2024 09:40
@remyleone remyleone added this pull request to the merge queue Mar 13, 2024
@remyleone remyleone added instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Mar 13, 2024
Merged via the queue into scaleway:master with commit 127f1ab Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve rendering of Subnets of private networks in the get cluster command

4 participants