Skip to content

feat(instance): support scratch volumes in servers #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 14, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Aug 28, 2023

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Aug 28, 2023
@Codelax Codelax self-assigned this Aug 28, 2023
@Codelax Codelax force-pushed the instance/scratch-volume branch 2 times, most recently from ac7d260 to a2be270 Compare September 6, 2023 13:26
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2023

Codecov Report

Patch coverage: 72.22% and project coverage change: -0.01% ⚠️

Comparison is base (0e50e1e) 75.71% compared to head (cabee25) 75.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3345      +/-   ##
==========================================
- Coverage   75.71%   75.71%   -0.01%     
==========================================
  Files         175      175              
  Lines       39052    39088      +36     
==========================================
+ Hits        29568    29594      +26     
- Misses       8413     8421       +8     
- Partials     1071     1073       +2     
Files Changed Coverage Δ
...nal/namespaces/instance/v1/custom_server_create.go 80.59% <72.22%> (-0.69%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax force-pushed the instance/scratch-volume branch from f4b2e9a to 7a50953 Compare September 14, 2023 11:34
@Codelax Codelax force-pushed the instance/scratch-volume branch from 7a50953 to c5119b6 Compare September 14, 2023 11:42
@Codelax Codelax marked this pull request as ready for review September 14, 2023 11:54
@quantumsheep quantumsheep added this pull request to the merge queue Sep 14, 2023
Merged via the queue into scaleway:master with commit b096eca Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants