Skip to content

feat(lb): support dhcp/ipam private network #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 1 commit into from
Aug 3, 2023
Merged

feat(lb): support dhcp/ipam private network #3321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cmd/scw/testdata/test-all-usage-lb-private-network-attach-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,13 @@ USAGE:
scw lb private-network attach <lb-id ...> [arg=value ...]

ARGS:
lb-id Load Balancer ID
private-network-id Private Network ID
lb-id Load Balancer ID
private-network-id Private Network ID
[dhcp-config.ip-id]
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)

DEPRECATED ARGS:
[static-config.ip-address.{index}] Array of a local IP address for the Load Balancer on this Private Network
[zone=fr-par-1] Zone to target. If none is passed will use default zone from the config (fr-par-1 | fr-par-2 | nl-ams-1 | nl-ams-2 | nl-ams-3 | pl-waw-1 | pl-waw-2)

FLAGS:
-h, --help help for attach
Expand Down
3 changes: 2 additions & 1 deletion docs/commands/lb.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,7 +1123,8 @@ scw lb private-network attach <lb-id ...> [arg=value ...]
|------|---|-------------|
| lb-id | Required | Load Balancer ID |
| private-network-id | Required | Private Network ID |
| static-config.ip-address.{index} | | Array of a local IP address for the Load Balancer on this Private Network |
| ~~static-config.ip-address.{index}~~ | Deprecated | Array of a local IP address for the Load Balancer on this Private Network |
| dhcp-config.ip-id | | |
| zone | Default: `fr-par-1`<br />One of: `fr-par-1`, `fr-par-2`, `nl-ams-1`, `nl-ams-2`, `nl-ams-3`, `pl-waw-1`, `pl-waw-2` | Zone to target. If none is passed will use default zone from the config |


Expand Down
6 changes: 6 additions & 0 deletions internal/namespaces/lb/v1/lb_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3254,6 +3254,12 @@ func lbPrivateNetworkAttach() *core.Command {
Name: "static-config.ip-address.{index}",
Short: `Array of a local IP address for the Load Balancer on this Private Network`,
Required: false,
Deprecated: true,
Positional: false,
},
{
Name: "dhcp-config.ip-id",
Required: false,
Deprecated: false,
Positional: false,
},
Expand Down