Skip to content

fix(sm): rename certificate type to be more generic #3298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix(sm): rename certificate type to be more generic #3298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-secret-secret-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ARGS:
[name] Name of the secret
[tags.{index}] List of the secret's tags
[description] Description of the secret
[type] Type of the secret (unknown_secret_type | opaque | network_edge_certificate)
[type] Type of the secret (unknown_secret_type | opaque | certificate)
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par)

FLAGS:
Expand Down
2 changes: 1 addition & 1 deletion docs/commands/secret.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ scw secret secret create [arg=value ...]
| name | | Name of the secret |
| tags.{index} | | List of the secret's tags |
| description | | Description of the secret |
| type | One of: `unknown_secret_type`, `opaque`, `network_edge_certificate` | Type of the secret |
| type | One of: `unknown_secret_type`, `opaque`, `certificate` | Type of the secret |
| region | Default: `fr-par`<br />One of: `fr-par` | Region to target. If none is passed will use default region from the config |


Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ require (
github.com/moby/buildkit v0.11.6
github.com/opencontainers/go-digest v1.0.0
github.com/pkg/errors v0.9.1
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230720143451-785dc161c15d
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230721074430-6966aee6e8df
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.7.0
github.com/spf13/pflag v1.0.5
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,8 +497,8 @@ github.com/rogpeppe/go-internal v1.10.0/go.mod h1:UQnix2H7Ngw/k4C5ijL5+65zddjncj
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230720143451-785dc161c15d h1:fMaLlUJQWVFQeQTMPi5AFXPyM/MZgyFdSo4tp5BOShg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230720143451-785dc161c15d/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230721074430-6966aee6e8df h1:LVutljqAyGnmpPt3pAjAEYgnWnesakRy3v111zsjrW4=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.19.0.20230721074430-6966aee6e8df/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/secure-systems-lab/go-securesystemslib v0.4.0 h1:b23VGrQhTA8cN2CbBw7/FulN9fTtqYUdS5+Oxzt+DUE=
github.com/sergi/go-diff v1.0.0/go.mod h1:0CfEIISq7TuYL3j771MWULgwwjU+GofnZX9QAmXWZgo=
Expand Down
2 changes: 1 addition & 1 deletion internal/namespaces/secret/v1alpha1/secret_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func secretSecretCreate() *core.Command {
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"unknown_secret_type", "opaque", "network_edge_certificate"},
EnumValues: []string{"unknown_secret_type", "opaque", "certificate"},
},
core.RegionArgSpec(scw.RegionFrPar),
},
Expand Down