Skip to content

fix(instance): complete image list fields #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 22, 2023

Fix #3234

@Codelax Codelax added bug instance Instance issues, bugs and feature requests labels Jun 22, 2023
@Codelax Codelax self-assigned this Jun 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3236 (c778a1c) into master (d2eda0b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3236      +/-   ##
==========================================
- Coverage   75.63%   75.60%   -0.03%     
==========================================
  Files         177      177              
  Lines       38446    38503      +57     
==========================================
+ Hits        29078    29112      +34     
- Misses       8300     8321      +21     
- Partials     1068     1070       +2     
Impacted Files Coverage Δ
internal/namespaces/instance/v1/custom_image.go 81.56% <100.00%> (-0.67%) ⬇️

... and 2 files with indirect coverage changes

@Codelax Codelax added this pull request to the merge queue Jun 22, 2023
Merged via the queue into scaleway:master with commit a5daf5f Jun 22, 2023
@Codelax Codelax deleted the fix/instance-image-list-tags branch June 22, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"tags" field is missing from command "scw -o json instance image list"
3 participants