Skip to content

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 1, 2023

Closes #3101

@Codelax Codelax added enhancement instance Instance issues, bugs and feature requests labels Jun 1, 2023
@Codelax Codelax self-assigned this Jun 1, 2023
@Codelax Codelax marked this pull request as draft June 1, 2023 13:52
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #3161 (5e89268) into master (eb63a03) will decrease coverage by 0.11%.
The diff coverage is 73.31%.

@@            Coverage Diff             @@
##           master    #3161      +/-   ##
==========================================
- Coverage   75.78%   75.68%   -0.11%     
==========================================
  Files         173      176       +3     
  Lines       37719    38222     +503     
==========================================
+ Hits        28585    28927     +342     
- Misses       8103     8230     +127     
- Partials     1031     1065      +34     
Impacted Files Coverage Δ
...ternal/namespaces/instance/v1/custom_ssh_config.go 60.88% <60.88%> (ø)
internal/namespaces/instance/v1/custom_ssh_key.go 84.37% <84.37%> (ø)
internal/namespaces/instance/v1/custom.go 98.21% <100.00%> (+0.13%) ⬆️

... and 6 files with indirect coverage changes

@Codelax Codelax force-pushed the feat/instance-ssh-utilities branch from 1903363 to e5ff9a6 Compare June 6, 2023 12:12
@Codelax Codelax force-pushed the feat/instance-ssh-utilities branch from e5ff9a6 to 38f4d8f Compare June 6, 2023 12:39
@Codelax Codelax marked this pull request as ready for review June 6, 2023 13:54
@Codelax Codelax force-pushed the feat/instance-ssh-utilities branch from 6f25a2b to 5e89268 Compare June 6, 2023 13:55
@remyleone remyleone added this pull request to the merge queue Jun 6, 2023
Merged via the queue into scaleway:master with commit e8e167c Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for helpers for ssh keys manipulation in instances
3 participants