feat(k8s): create PN automatically with cluster if none given #3152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
force-pushed
the
k8s_pn_id_required
branch
from
bb37714 to
58d29dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #3152 +/- ##
==========================================
- Coverage 75.61% 75.58% -0.03%
==========================================
Files 177 177
Lines 38287 38367 +80
==========================================
+ Hits 28951 29001 +50
- Misses 8272 8299 +27
- Partials 1064 1067 +3
|
Mia-Cross
force-pushed
the
k8s_pn_id_required
branch
from
c223f96 to
08527a1
Compare
|
Beware, that will break kosmos! |
remyleone
previously approved these changes
Jun 9, 2023
remyleone
requested changes
Jun 12, 2023
Mia-Cross
force-pushed
the
k8s_pn_id_required
branch
from
08527a1 to
0c6ca1c
Compare
jtherin
reviewed
Jun 13, 2023
Mia-Cross
force-pushed
the
k8s_pn_id_required
branch
4 times, most recently
from
eb80b8b to
6a35975
Compare
Mia-Cross
force-pushed
the
k8s_pn_id_required
branch
from
6a35975 to
5b2af5f
Compare
Mia-Cross
force-pushed
the
k8s_pn_id_required
branch
from
3b4bdec to
f37aa1f
Compare
remyleone
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a custom
clusterCreatefunction that creates a Private Network with the cluster if noprivate_network_idis given.