feat(wasm): export an autocomplete function #3148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3148 +/- ##
==========================================
- Coverage 75.82% 75.78% -0.05%
==========================================
Files 171 173 +2
Lines 37374 37719 +345
==========================================
+ Hits 28340 28585 +245
- Misses 8029 8103 +74
- Partials 1005 1031 +26 |
| words := append(cfg.LeftWords, cfg.SelectedWord) | ||
| words = append(words, cfg.RightWords...) | ||
|
|
||
| completeCommand := []string{"autocomplete", "complete", "zsh", strconv.FormatInt(indexToComplete, 10), "scw"} |
There was a problem hiding this comment.
Could ZSH be in the AutoCompleteConfig? Maybe depending on the different feature of a shell we want to configure them differently? I know that we won't have a different shell in the console but maybe we will have different autocomplete feature depending on the shell we target.
There was a problem hiding this comment.
Currently the exported command use the zsh complete command but the best method would be to call directly core.Autocomplete.
As you can see, the current arguments for this javascript function are copied from the Go function prototype.
func AutoComplete(ctx context.Context, leftWords []string, wordToComplete string, rightWords []string) *AutocompleteResponseBut the autocomplete function currently need a working context that is created in core.Bootstrap. To make it work quickly I directly just called the cli command to complete.
Autocomplete need to be refactored to avoid needing a context.
Also all the completion commands (zsh, bash, fish) are called with a different order of argument, that would require more support
There was a problem hiding this comment.
Could you add a comment about this directly in the code to give directions about how to refactor this code if you think it is going to be complex and time-consuming?
Closes #3111
Closes #3114
Currently not using directly autocomplete as it requires a filled Context, will be done in the future.
The completion tree is built upon each call.