Skip to content

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented May 11, 2023

Fix #3112
Added a config passed to the js run function.
Some platform dependent code was moved from core to platform. Will be improved when adding output configuration (termcaps)
Added a jshelpers package to handle js values

Had to fix some tests as by moving client creation it showed that ReloadClient skipped the client validation

@Codelax Codelax self-assigned this May 11, 2023
@Codelax Codelax marked this pull request as draft May 11, 2023 15:08
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Merging #3119 (36155af) into master (27c0fba) will increase coverage by 0.14%.
The diff coverage is 45.00%.

@@            Coverage Diff             @@
##           master    #3119      +/-   ##
==========================================
+ Coverage   75.76%   75.91%   +0.14%     
==========================================
  Files         170      170              
  Lines       37118    36964     -154     
==========================================
- Hits        28123    28061      -62     
+ Misses       8014     7931      -83     
+ Partials      981      972       -9     
Impacted Files Coverage Δ
cmd/scw/main.go 0.00% <0.00%> (ø)
internal/core/client.go 0.00% <0.00%> (-20.33%) ⬇️
internal/core/cobra_utils.go 68.78% <0.00%> (+1.55%) ⬆️
internal/core/testing.go 66.12% <50.00%> (-0.08%) ⬇️
internal/core/bootstrap.go 64.53% <100.00%> (+0.20%) ⬆️
internal/core/context.go 52.29% <100.00%> (+1.81%) ⬆️

... and 2 files with indirect coverage changes

@Codelax Codelax marked this pull request as ready for review May 12, 2023 11:49
@Codelax Codelax marked this pull request as draft May 12, 2023 14:18
@Codelax Codelax marked this pull request as ready for review May 12, 2023 15:35
@remyleone remyleone added this pull request to the merge queue May 16, 2023
Merged via the queue into scaleway:master with commit 13755b3 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm: jwt support
3 participants