Skip to content

feat: add timeout argument to wait commands #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 5, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented May 3, 2023

Closes #3017

@Codelax Codelax self-assigned this May 3, 2023
@Codelax Codelax changed the title feat: add timeout argument to wait for instance and apple-silicon feat: add timeout argument to wait commands May 3, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3102 (10eea3b) into master (ff568a1) will decrease coverage by 0.04%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##           master    #3102      +/-   ##
==========================================
- Coverage   75.78%   75.75%   -0.04%     
==========================================
  Files         169      169              
  Lines       36686    36702      +16     
==========================================
+ Hits        27804    27805       +1     
- Misses       7919     7934      +15     
  Partials      963      963              
Impacted Files Coverage Δ
internal/core/arg_specs.go 18.75% <0.00%> (-0.93%) ⬇️
.../namespaces/applesilicon/v1alpha1/custom_server.go 57.62% <0.00%> (ø)
internal/namespaces/instance/v1/custom_server.go 79.58% <10.00%> (-0.59%) ⬇️
internal/namespaces/baremetal/v1/custom_server.go 45.94% <11.11%> (-0.27%) ⬇️

@Codelax Codelax marked this pull request as ready for review May 3, 2023 14:44
@remyleone remyleone added this pull request to the merge queue May 5, 2023
Merged via the queue into scaleway:master with commit 9982c14 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify a timeout argument in all wait commands
3 participants