fix(rdb): connect to public or private endpoint by Monitob · Pull Request #3094 · scaleway/scaleway-cli

Monitob · 2023-04-26T13:19:50Z

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #3093

Release note for CHANGELOG:

Monitob self-assigned this Apr 26, 2023

Monitob added rdb Managed MySQL and PostgreSQL issues, bugs and feature requests bug labels Apr 26, 2023

remyleone reviewed Apr 26, 2023

View reviewed changes

Comment thread internal/namespaces/rdb/v1/custom_instance.go

Monitob force-pushed the fix-rdb-connect-to-engine-public-or-private branch from 558ca54 to 26f5111 Compare April 27, 2023 12:39

Monitob added 3 commits April 27, 2023 14:47

fix(rdb): connect to public or private endpoint

42f05b1

fix(rdb): add test

01f5592

Empty commit

1d7fc26

Monitob force-pushed the fix-rdb-connect-to-engine-public-or-private branch from 12b35ff to 1d7fc26 Compare April 27, 2023 12:48

remyleone approved these changes Apr 27, 2023

View reviewed changes

remyleone added this pull request to the merge queue Apr 27, 2023

Merged via the queue into scaleway:master with commit 6ecde0b Apr 27, 2023

Provide feedback