Skip to content

feat: wasm build #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 10, 2023
Merged

feat: wasm build #3024

merged 25 commits into from
May 10, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Apr 13, 2023 •
edited
Loading

Closes #2674

@Codelax Codelax self-assigned this Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023 •
edited
Loading

Codecov Report

❌ Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.76%. Comparing base (7af0b2a) to head (5255acd).
⚠️ Report is 1188 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/client.go 0.00% 12 Missing and 1 partial ⚠️
internal/core/cobra_utils.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3024      +/-   ##
==========================================
- Coverage   75.79%   75.76%   -0.03%     
==========================================
  Files         170      170              
  Lines       37106    37120      +14     
==========================================
+ Hits        28124    28125       +1     
- Misses       8002     8014      +12     
- Partials      980      981       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

remyleone
remyleone reviewed Apr 27, 2023
View reviewed changes
@remyleone remyleone added the priority:high New features label May 2, 2023
@Codelax Codelax marked this pull request as ready for review May 9, 2023 11:22
remyleone
remyleone previously approved these changes May 9, 2023
View reviewed changes
quantumsheep
quantumsheep requested changes May 9, 2023
View reviewed changes
quantumsheep
quantumsheep requested changes May 9, 2023
View reviewed changes
Copy link
Member

@quantumsheep quantumsheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

@Codelax Codelax added this pull request to the merge queue May 10, 2023
Merged via the queue into scaleway:master with commit 1c467ba May 10, 2023
@Codelax Codelax deleted the feat/wasm-build branch May 10, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantumsheep quantumsheep quantumsheep approved these changes

@remyleone remyleone remyleone left review comments

Assignees

@Codelax Codelax

Labels
enhancement priority:high New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: webasm build and interface
4 participants
@Codelax @codecov-commenter @remyleone @quantumsheep