-
Notifications
You must be signed in to change notification settings - Fork 155
feat(vpc): improve get private-network to show all attached resources #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3021 +/- ##
==========================================
- Coverage 75.76% 75.67% -0.09%
==========================================
Files 170 170
Lines 37118 37294 +176
==========================================
+ Hits 28123 28224 +101
- Misses 8014 8073 +59
- Partials 981 997 +16
|
remyleone
reviewed
Apr 13, 2023
remyleone
reviewed
May 16, 2023
internal/namespaces/vpc/v1/testdata/test-get-private-network-simple.golden
Outdated
Show resolved
Hide resolved
remyleone
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
priority:medium
Improvements that are not the main priority
ux
vpc
Virtual Private Cloud (VPC) issues, bugs and feature requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.