Skip to content

feat(vpc): improve get private-network to show all attached resources #3021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 17, 2023

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Apr 13, 2023

No description provided.

@yfodil yfodil added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Apr 13, 2023
@yfodil yfodil self-assigned this Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #3021 (04bea4a) into master (27c0fba) will decrease coverage by 0.09%.
The diff coverage is 63.05%.

@@            Coverage Diff             @@
##           master    #3021      +/-   ##
==========================================
- Coverage   75.76%   75.67%   -0.09%     
==========================================
  Files         170      170              
  Lines       37118    37294     +176     
==========================================
+ Hits        28123    28224     +101     
- Misses       8014     8073      +59     
- Partials      981      997      +16     
Impacted Files Coverage Δ
...ternal/namespaces/vpc/v1/custom_private_network.go 64.15% <63.05%> (-23.85%) ⬇️

@yfodil yfodil linked an issue Apr 13, 2023 that may be closed by this pull request
@remyleone remyleone added the priority:medium Improvements that are not the main priority label Apr 13, 2023
@remyleone remyleone added this pull request to the merge queue May 17, 2023
Merged via the queue into scaleway:master with commit 6b3d42b May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority:medium Improvements that are not the main priority ux vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for all kinds of resources in a private network
3 participants