Conversation
remyleone
commented
Apr 6, 2023
|
|
||
| // serverLocationMarshalerFunc marshals a instance.ServerLocation. | ||
| func serverLocationMarshalerFunc(i interface{}, opt *human.MarshalOpt) (string, error) { | ||
| func serverLocationMarshalerFunc(i interface{}, _ *human.MarshalOpt) (string, error) { |
Member
Author
There was a problem hiding this comment.
I wonder if we could use an interface here
Codecov Report
@@ Coverage Diff @@
## master #3005 +/- ##
=======================================
Coverage 75.41% 75.41%
=======================================
Files 163 163
Lines 34797 34797
=======================================
Hits 26242 26242
Misses 7653 7653
Partials 902 902
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Codelax
approved these changes
Apr 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG: