Skip to content

chore: bump golang-ci lint to latest #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 6, 2023
Merged

chore: bump golang-ci lint to latest #3005

merged 3 commits into from
Apr 6, 2023

Conversation

remyleone
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@@ -43,7 +43,7 @@ var (
)

// serverLocationMarshalerFunc marshals a instance.ServerLocation.
func serverLocationMarshalerFunc(i interface{}, opt *human.MarshalOpt) (string, error) {
func serverLocationMarshalerFunc(i interface{}, _ *human.MarshalOpt) (string, error) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could use an interface here

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2023

Codecov Report

Merging #3005 (f599dd3) into master (ec9afc7) will not change coverage.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master    #3005   +/-   ##
=======================================
  Coverage   75.41%   75.41%           
=======================================
  Files         163      163           
  Lines       34797    34797           
=======================================
  Hits        26242    26242           
  Misses       7653     7653           
  Partials      902      902           
Impacted Files Coverage Δ
cmd/scw/main.go 0.00% <0.00%> (ø)
internal/human/marshal_func.go 36.55% <100.00%> (ø)
internal/namespaces/account/v2alpha1/custom.go 72.46% <100.00%> (ø)
internal/namespaces/iam/v1alpha1/custom.go 62.50% <100.00%> (ø)
internal/namespaces/instance/v1/custom_image.go 82.22% <100.00%> (ø)
...al/namespaces/instance/v1/custom_security_group.go 55.32% <100.00%> (ø)
internal/namespaces/instance/v1/custom_server.go 79.82% <100.00%> (ø)
internal/namespaces/instance/v1/custom_volume.go 74.07% <100.00%> (ø)
internal/namespaces/rdb/v1/custom_backup.go 80.91% <100.00%> (ø)
internal/namespaces/rdb/v1/custom_instance.go 80.91% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Codelax Codelax added this pull request to the merge queue Apr 6, 2023
Merged via the queue into master with commit 1f5c070 Apr 6, 2023
@Codelax Codelax deleted the golangci-lint branch April 6, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants