feat(autocomplete): cache in arg completion instead of shell#2952
Merged
remyleone merged 1 commit intoscaleway:masterfrom Mar 27, 2023
Merged
feat(autocomplete): cache in arg completion instead of shell#2952remyleone merged 1 commit intoscaleway:masterfrom
remyleone merged 1 commit intoscaleway:masterfrom
Conversation
Codelax
force-pushed
the
feat/cache-arg-complete
branch
from
6ab36e7 to
6c05106
Compare
remyleone
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the quick cache feature would cache shell suggestions.
Writing
Would cache results, meaning you could not get completion when changing your word
I just added quickly a package to cache listing requests used in completion, this is very efficient when using shell.
Cache invalidate if using any other commands of this namespace, this is not perfect but it works quite well for now to avoid spamming requests and lagging out terminal.