Skip to content

feat(autocomplete): cache in arg completion instead of shell #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Mar 27, 2023

Previously, the quick cache feature would cache shell suggestions.
Writing

>>> f
        function
        fip
        ...

Would cache results, meaning you could not get completion when changing your word

>>> inst
       <nothing>

I just added quickly a package to cache listing requests used in completion, this is very efficient when using shell.
Cache invalidate if using any other commands of this namespace, this is not perfect but it works quite well for now to avoid spamming requests and lagging out terminal.

@Codelax Codelax force-pushed the feat/cache-arg-complete branch from 6ab36e7 to 6c05106 Compare March 27, 2023 14:46
@remyleone remyleone added this pull request to the merge queue Mar 27, 2023
Merged via the queue into scaleway:master with commit b17ca12 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants