fix(secret-manager): Move secret content in doc#2879
Closed
Cubox wants to merge 1 commit intoscaleway:masterfrom
Cubox:patch-1
Closed
fix(secret-manager): Move secret content in doc#2879Cubox wants to merge 1 commit intoscaleway:masterfrom Cubox:patch-1
Cubox wants to merge 1 commit intoscaleway:masterfrom
Cubox:patch-1
Conversation
The documentation contains a potentially harmful example, setting the secret in the description, instead of the proper data field.
Member
|
this file is automatically generated using scw-doc-gen |
remyleone
added
bug
documentation
priority:highest
Codecov Report
@@ Coverage Diff @@
## master #2879 +/- ##
=======================================
Coverage 74.64% 74.64%
=======================================
Files 144 144
Lines 28921 28921
=======================================
Hits 21588 21588
Misses 6585 6585
Partials 748 748 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Fixed with #2881 |
Member
|
@Cubox thanks for opening up this PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation contains a potentially harmful example, setting the secret in the description, instead of the proper data field.