Skip to content

feat(container): implement deploy workflow #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Mar 23, 2023
Merged

Conversation

quantumsheep
Copy link
Member

@quantumsheep quantumsheep commented Mar 14, 2023

Depends on #2876
Resolves #2855

@quantumsheep quantumsheep self-assigned this Mar 14, 2023
@quantumsheep quantumsheep marked this pull request as draft March 14, 2023 16:58
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Merging #2872 (d8611fd) into master (572ca85) will increase coverage by 0.05%.
The diff coverage is 70.08%.

@@            Coverage Diff             @@
##           master    #2872      +/-   ##
==========================================
+ Coverage   74.78%   74.84%   +0.05%     
==========================================
  Files         144      149       +5     
  Lines       29996    31989    +1993     
==========================================
+ Hits        22434    23943    +1509     
- Misses       6786     7208     +422     
- Partials      776      838      +62     
Impacted Files Coverage Δ
internal/core/bootstrap.go 68.94% <0.00%> (ø)
internal/core/socket_passthrough_transport.go 36.36% <36.36%> (ø)
internal/core/testing.go 61.62% <57.14%> (-0.24%) ⬇️
...rnal/namespaces/container/v1beta1/container_cli.go 79.89% <63.41%> (ø)
internal/namespaces/baremetal/v1/baremetal_cli.go 81.13% <67.60%> (-0.82%) ⬇️
...rnal/namespaces/container/v1beta1/custom_deploy.go 69.23% <69.23%> (ø)
...ernal/namespaces/marketplace/v2/marketplace_cli.go 78.13% <69.73%> (-8.03%) ⬇️
internal/namespaces/lb/v1/lb_cli.go 83.53% <73.81%> (-1.19%) ⬇️
internal/namespaces/container/v1beta1/custom.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@quantumsheep quantumsheep force-pushed the feat/container-deploy branch from 5c284da to d7064b4 Compare March 14, 2023 17:26
@quantumsheep quantumsheep force-pushed the feat/container-deploy branch 2 times, most recently from 4b9ee56 to 847e6d4 Compare March 17, 2023 16:52
@quantumsheep quantumsheep requested a review from remyleone March 17, 2023 17:09
@quantumsheep quantumsheep force-pushed the feat/container-deploy branch from 939fff7 to cf8d9da Compare March 20, 2023 17:31
@quantumsheep quantumsheep marked this pull request as ready for review March 20, 2023 17:32
@quantumsheep quantumsheep force-pushed the feat/container-deploy branch 2 times, most recently from d4b2beb to 6b28fd8 Compare March 22, 2023 14:14
@quantumsheep quantumsheep force-pushed the feat/container-deploy branch from 996fa61 to 4bcf7c4 Compare March 23, 2023 13:38
remyleone
remyleone previously approved these changes Mar 23, 2023
@remyleone remyleone enabled auto-merge March 23, 2023 15:14
@remyleone remyleone added this pull request to the merge queue Mar 23, 2023
Merged via the queue into master with commit c2a7193 Mar 23, 2023
@remyleone remyleone deleted the feat/container-deploy branch March 23, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container: add support for a deploy function
4 participants