feat(instance): add tags to private nics#2793
Merged
Codelax merged 6 commits intoscaleway:masterfrom Feb 28, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2793 +/- ##
=======================================
Coverage 75.18% 75.18%
=======================================
Files 137 137
Lines 27805 27833 +28
=======================================
+ Hits 20904 20926 +22
- Misses 6186 6192 +6
Partials 715 715
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Codelax
previously approved these changes
Feb 24, 2023
remyleone
reviewed
Feb 24, 2023
| scaleway-sdk-go: *instance.ListPrivateNICsResponse does not support pagination | ||
| 🟥🟥🟥 JSON STDERR 🟥🟥🟥 | ||
| { | ||
| "error": "scaleway-sdk-go: *instance.ListPrivateNICsResponse does not support pagination" |
Codelax
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.