Skip to content

feat(rdb): rename ACL add/delete arguments #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 5, 2022
Merged

feat(rdb): rename ACL add/delete arguments #2571

merged 15 commits into from
Dec 5, 2022

Conversation

@yfodil
Copy link
Contributor

@yfodil yfodil commented Nov 3, 2022 •
edited
Loading

feat #1392

@yfodil yfodil self-assigned this Nov 3, 2022
@yfodil yfodil added enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests labels Nov 3, 2022
@yfodil yfodil marked this pull request as ready for review November 3, 2022 15:30
@yfodil yfodil linked an issue Nov 3, 2022 that may be closed by this pull request
Inconsistency in naming arguments in the ACL add/delete #1392
Closed
remyleone
remyleone reviewed Nov 4, 2022
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #2571 (99cc231) into master (121b725) will increase coverage by 0.09%.
The diff coverage is 90.62%.

@@            Coverage Diff             @@
##           master    #2571      +/-   ##
==========================================
+ Coverage   76.60%   76.70%   +0.09%     
==========================================
  Files         131      131              
  Lines       23839    23901      +62     
==========================================
+ Hits        18263    18334      +71     
+ Misses       4979     4969      -10     
- Partials      597      598       +1
Impacted Files Coverage Δ
internal/namespaces/rdb/v1/custom_acl.go 85.54% <90.62%> (+47.44%) ⬆️
internal/namespaces/rdb/v1/rdb_cli.go 85.41% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

remyleone
remyleone reviewed Nov 21, 2022
View reviewed changes
@remyleone remyleone merged commit 77ff45b into scaleway:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@yfodil yfodil

Labels

enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistency in naming arguments in the ACL add/delete

3 participants

@yfodil @codecov-commenter @remyleone