Skip to content

feat(rdb): add password generator #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2023
Merged

feat(rdb): add password generator #2557

merged 3 commits into from
May 17, 2023

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented Oct 20, 2022 •
edited
Loading

feat #1155

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 20, 2022
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 20, 2022
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022 •
edited
Loading

Codecov Report

Merging #2557 (6e361ee) into master (87a2c54) will decrease coverage by 0.01%.
The diff coverage is 79.22%.

@@            Coverage Diff             @@
##           master    #2557      +/-   ##
==========================================
- Coverage   75.76%   75.76%   -0.01%     
==========================================
  Files         170      171       +1     
  Lines       37120    37346     +226     
==========================================
+ Hits        28125    28295     +170     
- Misses       8014     8053      +39     
- Partials      981      998      +17
Impacted Files Coverage Δ
internal/passwordgenerator/password_generator.go 52.94% <52.94%> (ø)
internal/namespaces/rdb/v1/custom_instance.go 79.15% <85.18%> (+0.85%) ⬆️
internal/namespaces/rdb/v1/custom_user.go 80.76% <87.50%> (+10.76%) ⬆️
internal/namespaces/rdb/v1/custom.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

remyleone
remyleone reviewed Oct 20, 2022
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 21, 2022
View reviewed changes
@yfodil yfodil marked this pull request as ready for review October 26, 2022 14:45
@yfodil yfodil linked an issue Oct 26, 2022 that may be closed by this pull request
Have an option to generate a valid password directly from the CLI when create/updating user #1155
Closed
@yfodil yfodil self-assigned this Nov 2, 2022
@yfodil yfodil added enhancement rdb Managed MySQL and PostgreSQL issues, bugs and feature requests labels Nov 2, 2022
remyleone
remyleone reviewed Nov 8, 2022
View reviewed changes
@yfodil yfodil marked this pull request as draft December 20, 2022 09:33
@remyleone remyleone added the priority:medium Improvements that are not the main priority label Jan 25, 2023
@yfodil yfodil force-pushed the feat/password_generator branch from 334a091 to f7c0149 Compare May 16, 2023 07:33
github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2023
View reviewed changes
internal/namespaces/rdb/v1/custom_instance.go
if err != nil {
return nil, err
}
fmt.Printf("Your generated password is %s \n", createInstanceRequest.Password)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

[Sensitive data returned by an access to Password](1) flows to a logging call. [Sensitive data returned by an access to password](2) flows to a logging call. [Sensitive data returned by an access to Password](3) flows to a logging call.
internal/namespaces/rdb/v1/custom_user.go
if err != nil {
return nil, err
}
fmt.Printf("Your generated password is %s \n", createUserRequest.Password)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

[Sensitive data returned by an access to Password](1) flows to a logging call. [Sensitive data returned by an access to password](2) flows to a logging call. [Sensitive data returned by an access to Password](3) flows to a logging call.
internal/namespaces/rdb/v1/custom_user.go
if customRequest.GeneratePassword && customRequest.Password == nil {
updateUserRequest.Password = new(string)
*updateUserRequest.Password, err = passwordgenerator.GeneratePassword(21, 1, 1, 1, 1)
fmt.Printf("Your generated password is %v \n", *updateUserRequest.Password)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

[Sensitive data returned by an access to Password](1) flows to a logging call. [Sensitive data returned by an access to Password](2) flows to a logging call.
@yfodil yfodil marked this pull request as ready for review May 16, 2023 08:52
@remyleone remyleone added this pull request to the merge queue May 17, 2023
Merged via the queue into scaleway:master with commit ff2d186 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@yfodil yfodil

Labels
enhancement priority:medium Improvements that are not the main priority rdb Managed MySQL and PostgreSQL issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have an option to generate a valid password directly from the CLI when create/updating user
3 participants
@yfodil @codecov-commenter @remyleone