fix(core): do not require a config file if required env vars are set#2550
Merged
remyleone merged 3 commits intoscaleway:masterfrom Oct 17, 2022
Merged
Conversation
Codelax
approved these changes
Oct 17, 2022
Member
Codelax
left a comment
There was a problem hiding this comment.
LGTM
Thanks for your contribution
remyleone
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
A regression was introduced in the 2.6.0 release where the CLI will exit with the following error:
Even though all the required env vars
SCW_ACCESS_KEY,SCW_SECRET_KEY,SCW_ORGANIZATION_ID,SCW_DEFAULT_ORGANIZATION_ID,SCW_ZONEare set.The same invocation of the CLI used to work fine with the 2.5.x releases
Proposed Fix
Change the client creation logic to no longer require a configuration file, but instead:
Release note for CHANGELOG: