feat(instance): add image update command#2539
Merged
remyleone merged 5 commits intoscaleway:masterfrom Oct 7, 2022
Merged
Conversation
remyleone
reviewed
Oct 6, 2022
| return c | ||
| } | ||
|
|
||
| // |
Contributor
Author
There was a problem hiding this comment.
Because the UpdateImage method has been hand coded in the SDK
Member
There was a problem hiding this comment.
Could we check with the instance team if the update image could be generated now? Maybe the reasons of why it was hardcoded are no long true and it could be generated just like any other function
Codecov Report
@@ Coverage Diff @@
## master #2539 +/- ##
==========================================
+ Coverage 75.82% 75.88% +0.05%
==========================================
Files 126 126
Lines 21829 21920 +91
==========================================
+ Hits 16552 16634 +82
- Misses 4719 4727 +8
- Partials 558 559 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
remyleone
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat #2217