Merged
Conversation
2033388 to
5560320
Compare
5560320 to
bdf0608
Compare
Monitob
reviewed
Sep 29, 2022
remyleone
reviewed
Oct 5, 2022
Member
Author
move alias resource to config: |
Codecov Report
@@ Coverage Diff @@
## master #2501 +/- ##
==========================================
- Coverage 75.15% 74.83% -0.32%
==========================================
Files 134 142 +8
Lines 26080 28207 +2127
==========================================
+ Hits 19600 21109 +1509
- Misses 5810 6369 +559
- Partials 670 729 +59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
a2861b8 to
a85b7e9
Compare
kindermoumoute
requested changes
Mar 3, 2023
Contributor
kindermoumoute
left a comment
There was a problem hiding this comment.
Still think we should suggest to add some usefull aliases somewhere, maybe in scw init?
remyleone
reviewed
Mar 3, 2023
remyleone
previously approved these changes
Mar 6, 2023
remyleone
reviewed
Mar 6, 2023
Co-authored-by: Olivier Cano <kindermoumoute@users.noreply.github.com>
remyleone
approved these changes
Mar 6, 2023
kindermoumoute
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #947
Still need to fix completion when using an aliased namespace likescw k8s cl cre<TAB>Ideas
isc = instance server create,isl = instance server listIt creates many duplicates, we could show different alternative on completion.
scw isc<tab> ==> scw instance server create |Tricky to give multiple words in one suggestions depending on used shell (bash, zsh...)