Skip to content

feat(function): add support to update runtime #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 3 commits into from
Apr 21, 2022
Merged

feat(function): add support to update runtime #2280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afe5bb9
feat: update generated cli
scaleway-bot Apr 21, 2022
c53c9a3
Fix
remyleone Apr 21, 2022
9b4cb93
Fix
remyleone Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-function-function-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ ARGS:
[environment-variables.value.{key}]
[min-scale]
[max-scale]
[runtime] (unknown_runtime | golang | python | python3 | node8 | node10 | node14 | node16 | node17 | python37 | python38 | python39 | python310 | go113 | go117 | go118)
[memory-limit]
[timeout.seconds]
[timeout.nanos]
Expand Down
1 change: 1 addition & 0 deletions docs/commands/function.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ scw function function update <function-id ...> [arg=value ...]
| environment-variables.value.{key} | | |
| min-scale | | |
| max-scale | | |
| runtime | One of: `unknown_runtime`, `golang`, `python`, `python3`, `node8`, `node10`, `node14`, `node16`, `node17`, `python37`, `python38`, `python39`, `python310`, `go113`, `go117`, `go118` | |
| memory-limit | | |
| timeout.seconds | | |
| timeout.nanos | | |
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ require (
github.com/kubernetes-client/go-base v0.0.0-20190205182333-3d0e39759d98
github.com/mattn/go-colorable v0.1.12
github.com/mattn/go-isatty v0.0.14
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220414122539-592cf1cf6e45
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220421084625-8f575ff71a1f
github.com/spf13/cobra v1.4.0
github.com/spf13/pflag v1.0.5
github.com/stretchr/testify v1.7.1
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINE
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220414122539-592cf1cf6e45 h1:5e+Ch1im2kahJ7tuyQsufZyISoFaDVkbMRBTkg8Ap2Q=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220414122539-592cf1cf6e45/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220421084625-8f575ff71a1f h1:G/TDvOCVJsZPaIXvddsvFyxJKNvE0LA4oJN9UDhcS8U=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.9.0.20220421084625-8f575ff71a1f/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
github.com/sergi/go-diff v1.2.0 h1:XU+rvMAioB0UC3q1MFrIQy4Vo5/4VsRDQQXHsEya6xQ=
github.com/sergi/go-diff v1.2.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
github.com/spf13/cobra v1.4.0 h1:y+wJpx64xcgO1V+RcnwW0LEHxTKRi2ZDPSBjWnrg88Q=
Expand Down
7 changes: 7 additions & 0 deletions internal/namespaces/function/v1beta1/function_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,13 @@ func functionFunctionUpdate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "runtime",
Required: false,
Deprecated: false,
Positional: false,
EnumValues: []string{"unknown_runtime", "golang", "python", "python3", "node8", "node10", "node14", "node16", "node17", "python37", "python38", "python39", "python310", "go113", "go117", "go118"},
},
{
Name: "memory-limit",
Required: false,
Expand Down