Skip to content

feat(k8s): add a default generated name for create cluster and create pool #1779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 3 commits into from
Feb 19, 2021
Merged

feat(k8s): add a default generated name for create cluster and create pool #1779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62dbd07
feat(k8s): add a default generated name for create cluster and create…
scaleway-bot Feb 19, 2021
706b803
Fix
remyleone Feb 19, 2021
0e5d4ba
Fix
remyleone Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-k8s-cluster-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ EXAMPLES:

ARGS:
[project-id] Project ID to use. If none is passed the default project ID will be used
name The name of the cluster
name=<generated> The name of the cluster
[description] The description of the cluster
[tags.{index}] The tags associated with the cluster
version The Kubernetes version of the cluster
Expand Down
2 changes: 1 addition & 1 deletion cmd/scw/testdata/test-all-usage-k8s-pool-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ EXAMPLES:

ARGS:
cluster-id The ID of the cluster in which the pool will be created
name The name of the pool
name=<generated> The name of the pool
node-type The node type is the type of Scaleway Instance wanted for the pool
[placement-group-id] The placement group ID in which all the nodes of the pool will be created
[autoscaling] The enablement of the autoscaling feature for the pool
Expand Down
2 changes: 2 additions & 0 deletions internal/namespaces/k8s/v1/k8s_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ func k8sClusterCreate() *core.Command {
Required: true,
Deprecated: false,
Positional: false,
Default: core.RandomValueGenerator("k8s"),
},
{
Name: "description",
Expand Down Expand Up @@ -1190,6 +1191,7 @@ func k8sPoolCreate() *core.Command {
Required: true,
Deprecated: false,
Positional: false,
Default: core.RandomValueGenerator("pool"),
},
{
Name: "node-type",
Expand Down