Skip to content

feat(as): add support for wait command and wait flag#1745

Merged
remyleone merged 3 commits intoscaleway:masterfrom
remyleone:as_wait
Feb 4, 2021
Merged

feat(as): add support for wait command and wait flag#1745
remyleone merged 3 commits intoscaleway:masterfrom
remyleone:as_wait

Conversation

@remyleone
Copy link
Copy Markdown
Member

@remyleone remyleone commented Feb 4, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

kindermoumoute
kindermoumoute approved these changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kindermoumoute kindermoumoute left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Add a golden test as soon as you get stock in production 🤞

@remyleone remyleone merged commit c9423ba into scaleway:master Feb 4, 2021
@remyleone remyleone deleted the as_wait branch February 4, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kindermoumoute kindermoumoute kindermoumoute approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remyleone @kindermoumoute