Skip to content

feat(k8s): add max_graceful_termination_sec to autoscaler flag #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remyleone merged 3 commits into from
Nov 30, 2020
Merged

feat(k8s): add max_graceful_termination_sec to autoscaler flag #1572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c53d249
feat(k8s): add max_graceful_termination_sec to autoscaler flag
scaleway-bot Nov 27, 2020
7c6e6f3
Fix
remyleone Nov 30, 2020
86fdc0c
Fix
remyleone Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-k8s-cluster-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ ARGS:
[autoscaler-config.expendable-pods-priority-cutoff] Pods with priority below cutoff will be expendable
[autoscaler-config.scale-down-unneeded-time] How long a node should be unneeded before it is eligible for scale down
[autoscaler-config.scale-down-utilization-threshold] Node utilization level, defined as sum of requested resources divided by capacity, below which a node can be considered for scale down
[autoscaler-config.max-graceful-termination-sec] Maximum number of seconds the cluster autoscaler waits for pod termination when trying to scale down a node
[auto-upgrade.enable] Whether or not auto upgrade is enabled for the cluster
[auto-upgrade.maintenance-window.start-hour] The start hour of the 2-hour maintenance window
[auto-upgrade.maintenance-window.day] The day of the week for the maintenance window (any | monday | tuesday | wednesday | thursday | friday | saturday | sunday)
Expand Down
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-k8s-cluster-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ ARGS:
[autoscaler-config.expendable-pods-priority-cutoff] Pods with priority below cutoff will be expendable
[autoscaler-config.scale-down-unneeded-time] How long a node should be unneeded before it is eligible for scale down
[autoscaler-config.scale-down-utilization-threshold] Node utilization level, defined as sum of requested resources divided by capacity, below which a node can be considered for scale down
[autoscaler-config.max-graceful-termination-sec] Maximum number of seconds the cluster autoscaler waits for pod termination when trying to scale down a node
[enable-dashboard] The new value of the Kubernetes Dashboard enablement
[ingress] The new Ingress Controller for the cluster (unknown_ingress | none | nginx | traefik | traefik2)
[auto-upgrade.enable] Whether or not auto upgrade is enabled for the cluster
Expand Down
14 changes: 14 additions & 0 deletions internal/namespaces/k8s/v1/k8s_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,13 @@ func k8sClusterCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "autoscaler-config.max-graceful-termination-sec",
Short: `Maximum number of seconds the cluster autoscaler waits for pod termination when trying to scale down a node`,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "auto-upgrade.enable",
Short: `Whether or not auto upgrade is enabled for the cluster`,
Expand Down Expand Up @@ -671,6 +678,13 @@ func k8sClusterUpdate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "autoscaler-config.max-graceful-termination-sec",
Short: `Maximum number of seconds the cluster autoscaler waits for pod termination when trying to scale down a node`,
Required: false,
Deprecated: false,
Positional: false,
},
{
Name: "enable-dashboard",
Short: `The new value of the Kubernetes Dashboard enablement`,
Expand Down